renderer_vulkan: Introduce shader HLE system with copy shader implementation. #1683

squidbus · 2024-12-07T14:30:05Z

Introduces a system for implementing more efficient HLE macros for simple shaders.

In this case, implements a macro for a copy shader used by Bloodborne to copy arbitrary blocks of memory from one buffer to another. Currently this shader is responsible for big spikes in memory usage from mapping 2GB+ buffers of memory space to arbitrarily copy between. On a real console this would not be an issue since it just provides a window into the memory range, but for us this results in buffer memory allocations to cover the entire range.

By implementing this shader in HLE we can avoid these giant buffer allocations, instead only mapping much smaller areas where the copy actually occurs. This should eliminate memory spikes, reduce overall VRAM usage, and be generally more performant. We hope to have a more low-level solution for this problem in the future, but pending that this is a good way to keep memory usage under control and improve performance.

This also allows Bloodborne to go in-game on macOS (if compiled using the latest dev build of MoltenVK) since this shader was the main blocker for that. Still needs some more improvements to be fully stable.

Thanks to @raphaelthegreat for implementing the algorithm to batch the copies together.

ngoquang2708 · 2024-12-07T14:48:34Z

Great news for SteamDeck owner!

GHU7924 · 2024-12-07T15:48:39Z

Steam Deck OLED

Build 06471fe

[Debug] page_manager.cpp:operator():36: Assertion Failed!
Operation not permitted

shad_log.txt

ZuwasieMan · 2024-12-07T15:51:37Z

One question @squidbus, can we expect a performance improvement in windows too? Thanks

squidbus · 2024-12-07T15:59:55Z

Steam Deck OLED

Build 06471fe

[Debug] page_manager.cpp:operator():36: Assertion Failed!
Operation not permitted

Have you checked on main? This doesn't look like something that would be related to this PR.

One question @squidbus, can we expect a performance improvement in windows too? Thanks

I think so.

StevenMiller123 · 2024-12-07T16:03:03Z

@GHU7924 Your error comes from the texel PR, which enabled userfaultfd by default. As a result of this, you'll need to run shadPS4 with sudo

Da-nu · 2024-12-07T16:44:29Z

This causes P5D (Not P3D, P4D, or P5R though) to crash after the title screen in pro mode. It causes an assertion failure on texture_cache.cpp:operator():213:
shad_log.txt

squidbus · 2024-12-07T16:46:06Z

This causes P5D (Not P3D, P4D, or P5R though) to crash after the title screen in pro mode. It causes an assertion failure on texture_cache.cpp:operator():213: shad_log.txt

This PR does nothing that would effect that game, I would bet you may see that on main sometimes.

EDIT: I am indeed seeing that crash on the current main.

GHU7924 · 2024-12-07T16:55:23Z

@squidbus @StevenMiller123 It looks like you're right and it doesn't apply to this PR, I'm sorry.

I recently wrote a comment about my experience playing Bloodborne on Steam Deck OLED. #1641 (comment)
The game worked for me, after that I no longer ran the emulator on the Steam Deck, deciding to check it out after a while. I downloaded your Build to give you feedback, but it didn't work out. I have also updated the Main build now and there is the same error, so once again I apologize.

Since I don't know much about Linux, I'll leave it as it is for now.

EDIT: As for Windows, I feel that performance has improved and stabilized.

rafael-57 · 2024-12-07T16:57:45Z

THANK YOU!! I was only able to do one test run since my PC has blue screen issues but it looks great so far.

This addresses issue #1547

Foul-Tarnished · 2024-12-07T17:24:38Z

Hopefully this make the 4K game patch more stable ?
And running on anything else than a 4090 😅

Missake212 · 2024-12-07T17:39:52Z

Made a quick video showcasing the difference if anyone's interested, pretty short and it's only in Central Yharnam but you can notice the spikes being gone in character creation
https://www.youtube.com/watch?v=jelm2Kkrrg4

…y shader implementation. shadps4-emu#1683

numity · 2024-12-08T12:29:13Z

20241208-1216-08.0512223.mp4

I have this bug with the this new build, I think could be because of the ram fix

numity · 2024-12-08T12:32:43Z

Untitled.video.4.mp4

Here is another example of Boykimma on discord

squidbus · 2024-12-08T12:48:29Z

Please send a log as well

numity · 2024-12-08T13:33:44Z

shad_log.txt
Here is the log on my PC

squidbus · 2024-12-08T13:36:33Z

Here is the log on my PC

This is using an unofficial build outside of this PR, need the issue to be confirmed comparing main shadPS4 releases to builds from this PR.

numity · 2024-12-08T13:40:25Z

sorry my bad, give me 2 minutes

squidbus · 2024-12-08T13:43:39Z

Also needs to be with no mods, just to be sure.

numity · 2024-12-08T13:51:43Z

shad_log.txt
Here is the correct log, please let me know if this work

squidbus · 2024-12-08T13:54:02Z

Here is the correct log, please let me know if this work

You still have patches enabled. I need to know that this issue happens with this PR and no patches, and does not happen on main with no patches.

numity · 2024-12-08T13:59:43Z

Okay, I just delete the user folder and now boot the game from fresh, no patch, no mod.
Here is the log file:

https://github.com/user-attachments/assets/ea72ad6e-d802-4a85-9bc7-8e67b4fccbf5
shad_log.txt

boykimma · 2024-12-08T14:16:41Z

Here is my log
shad_log.txt

…y shader implementation. shadps4-emu#1683

squidbus · 2024-12-08T17:58:13Z

Issue is determined to be an existing one that is exposed more heavily by this PR. Would be fixed with completed version of #1451

…y shader implementation. shadps4-emu#1683

squidbus · 2024-12-08T18:39:58Z

Pushed something that should fix the issue for now. Subresource uploads will likely provide a more efficient fix but this should provide a good fallback to catch any cases where ObtainViewBuffer is used with partial GPU-modified overlap.

…ntation. Co-authored-by: TheTurtle <[email protected]>

…y shader implementation. shadps4-emu#1683

AxeKeeper · 2024-12-09T11:00:05Z

shadPS4.exe.2024.12.09.-.13.47.27.03.1.mp4

Here i found another two. Above the door 1st one

AxeKeeper · 2024-12-09T11:00:16Z

shadPS4.exe.2024.12.09.-.13.54.17.04.1.mp4

AxeKeeper · 2024-12-09T11:00:33Z

shad_log.txt

squidbus · 2024-12-09T11:07:57Z

Needs comparison to main releases.

squidbus · 2024-12-09T11:08:48Z

Actually from your log it looks like you are already on main, those issues are not relevant to this PR.

AxeKeeper · 2024-12-09T11:11:11Z

Actually from your log it looks like you are already on main, those issues are not relevant to this PR.

Oh. Ok. I just don’t know which PR to send them to. I thought it was the same problem and sent it here.

squidbus · 2024-12-09T11:12:16Z

Oh. Ok. I just don’t know which PR to send them to. I thought it was the same problem and sent it here.

It's only relevant if its something that happens with this PR builds and not on main releases.

Missake212 · 2024-12-09T11:13:51Z

Actually from your log it looks like you are already on main, those issues are not relevant to this PR.

Btw these are not issues, it's just the lod, it happens on PS4 too I just checked

AxeKeeper · 2024-12-09T11:22:12Z

Actually from your log it looks like you are already on main, those issues are not relevant to this PR.

Btw these are not issues, it's just the lod, it happens on PS4 too I just checked
Ooh. I didn't even know about it. I thought Sony didn’t like even this kind of "issues". Well, if so, I'm glad it's not related to the emulator.

Missake212 · 2024-12-10T09:09:18Z

This PR allows BB to be played on an iGPU now, great work !
https://www.youtube.com/watch?v=v5ouCyh5NtY

Foul-Tarnished · 2024-12-10T15:39:57Z

Great amazing work now bb no longer asserts on igpu (fixes #765)

warp to Hunter's Dream causes vertex explosions Might be a regression

Man this is so unrelated to what this PR touched.

Also vertex explosions are pretty random

…ntation. (shadps4-emu#1683) * renderer_vulkan: Introduce shader HLE system with copy shader implementation. Co-authored-by: TheTurtle <[email protected]> * buffer_cache: Handle obtaining buffer views partially within buffers. * vk_shader_hle: Make more efficient --------- Co-authored-by: TheTurtle <[email protected]>

…mentation. (shadps4-emu#1683) * renderer_vulkan: Introduce shader HLE system with copy shader implementation. Co-authored-by: TheTurtle <[email protected]> * buffer_cache: Handle obtaining buffer views partially within buffers. * vk_shader_hle: Make more efficient

C0rn3j mentioned this pull request Dec 7, 2024

[Aggregate Issue] Bloodborne - Various bugs/Known problems on each platform #1641

Open

29 tasks

diegolix29 added a commit to diegolix29/shadPS4 that referenced this pull request Dec 7, 2024

Ram spike fix - renderer_vulkan: Introduce shader HLE system with cop…

2eb548e

…y shader implementation. shadps4-emu#1683

squidbus force-pushed the copy-shader-hle branch from 06471fe to 8e7ec9e Compare December 8, 2024 15:18

diegolix29 added a commit to diegolix29/shadPS4 that referenced this pull request Dec 8, 2024

Ram spike fix - renderer_vulkan: Introduce shader HLE system with cop…

1727fb0

…y shader implementation. shadps4-emu#1683

Foul-Tarnished mentioned this pull request Dec 8, 2024

Devtools - Shader editing #1705

Merged

diegolix29 added a commit to diegolix29/shadPS4 that referenced this pull request Dec 8, 2024

Ram spike fix - renderer_vulkan: Introduce shader HLE system with cop…

b469f76

…y shader implementation. shadps4-emu#1683

C0rn3j mentioned this pull request Dec 8, 2024

Some files in the repository are saved as CRLF, breaking utilities like patch #1706

Closed

squidbus and others added 2 commits December 8, 2024 15:03

renderer_vulkan: Introduce shader HLE system with copy shader impleme…

84e8168

…ntation. Co-authored-by: TheTurtle <[email protected]>

buffer_cache: Handle obtaining buffer views partially within buffers.

cc0c498

squidbus force-pushed the copy-shader-hle branch from 1d6f31a to cc0c498 Compare December 8, 2024 23:04

diegolix29 added a commit to diegolix29/shadPS4 that referenced this pull request Dec 9, 2024

Ram spike fix - renderer_vulkan: Introduce shader HLE system with cop…

1bd28f0

…y shader implementation. shadps4-emu#1683

vk_shader_hle: Make more efficient

363c6c1

raphaelthegreat merged commit e5e1aba into shadps4-emu:main Dec 10, 2024
20 checks passed

hgh32 mentioned this pull request Dec 11, 2024

Bloodborne graphics issues on Intel GPU #1739

Closed

This was referenced Dec 22, 2024

Unusual crash for bloodborne everytime I try to boot it with a new build #694

Closed

crash when entering character creation screen in Bloodborne #1540

Closed

black screen launching BB 1.09 steamos 3.6.12 #1246

Closed

squidbus deleted the copy-shader-hle branch January 27, 2025 12:54

Uh oh!

renderer_vulkan: Introduce shader HLE system with copy shader implementation. #1683

renderer_vulkan: Introduce shader HLE system with copy shader implementation. #1683

Uh oh!

Conversation

squidbus commented Dec 7, 2024

Uh oh!

ngoquang2708 commented Dec 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GHU7924 commented Dec 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZuwasieMan commented Dec 7, 2024

Uh oh!

squidbus commented Dec 7, 2024

Uh oh!

StevenMiller123 commented Dec 7, 2024

Uh oh!

Da-nu commented Dec 7, 2024

Uh oh!

squidbus commented Dec 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GHU7924 commented Dec 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rafael-57 commented Dec 7, 2024

Uh oh!

Foul-Tarnished commented Dec 7, 2024

Uh oh!

Missake212 commented Dec 7, 2024

Uh oh!

numity commented Dec 8, 2024

Uh oh!

numity commented Dec 8, 2024

Uh oh!

squidbus commented Dec 8, 2024

Uh oh!

numity commented Dec 8, 2024

Uh oh!

squidbus commented Dec 8, 2024

Uh oh!

numity commented Dec 8, 2024

Uh oh!

squidbus commented Dec 8, 2024

Uh oh!

numity commented Dec 8, 2024

Uh oh!

squidbus commented Dec 8, 2024

Uh oh!

numity commented Dec 8, 2024

Uh oh!

boykimma commented Dec 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

squidbus commented Dec 8, 2024

Uh oh!

squidbus commented Dec 8, 2024

Uh oh!

AxeKeeper commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AxeKeeper commented Dec 9, 2024

Uh oh!

AxeKeeper commented Dec 9, 2024

Uh oh!

squidbus commented Dec 9, 2024

Uh oh!

squidbus commented Dec 9, 2024

Uh oh!

AxeKeeper commented Dec 9, 2024

Uh oh!

squidbus commented Dec 9, 2024

Uh oh!

Missake212 commented Dec 9, 2024

Uh oh!

AxeKeeper commented Dec 9, 2024

Uh oh!

Missake212 commented Dec 10, 2024

ngoquang2708 commented Dec 7, 2024 •

edited

Loading

GHU7924 commented Dec 7, 2024 •

edited

Loading

squidbus commented Dec 7, 2024 •

edited

Loading

GHU7924 commented Dec 7, 2024 •

edited

Loading

boykimma commented Dec 8, 2024 •

edited

Loading

AxeKeeper commented Dec 9, 2024 •

edited

Loading