Skip to content

Made the URP shaders work in 2d light environment, but just show object own colors, don't react to 2d lights. #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 819 commits into
base: release/legacy/2.0
Choose a base branch
from

Conversation

H3idi-X
Copy link
Contributor

@H3idi-X H3idi-X commented Jun 13, 2025

Made the URP shaders work in 2d light environment, but just show object own colors, don't react to 2d lights.

H3idi-X added 30 commits April 3, 2022 06:41
* Fixed Indent in NoramMap Settings.
* GuiLayout.Label() in UTS3GUI.cs is replaced to EditorGUILayout.LabelField().
* Re-organizing tips in UTS3GUI.cs

* * Renamed `Outline Sampler` in Ontline foldout header to `Outline Width Map`.
* Renamed `Outline-tex` in Ontline foldout header to `Outline Color Map`.

* fixed typo.

* * Renamed Culling mode itemes from `CullingOff`, `FrontCulling` and `BackCulling` to `Off`, `Frontface` and `Backface`.
* Renamed `Receive System Shadows` to `Receive Shadows`.
* Renamed `Shadow Mask on Highlights` to `Dim Highlights in Shadow Area`.
* Renamed `Highlight Power on Shadows` to `Highlight Power in Shadow area`.
* Renamed `Camera Rolling Stabilizer` to `Stabilize Camera Rolling`.
* Renamed `ViewShift of Color` to `Color Shifting with View Angle`.
* Renamed `ViewShift` to `Shifting Target Color`.
* Renamed `Use Outline Texture` to `Outline Color Map`.
* Renamed `Use Baked Normal for Outline` to `Baked Normalmap`.
* Added Tips to Culling Mode popup menu in the inspector window.
* Added Tips to GUI Toggles in the inspector window.

* * Added Tips to Range Properties in the inspector window.
* struct RangeProperty is a class now.

* Recreated RengeProperty class constructor in order not to type a lot.

* On the way to replace MaterialEditor.RangeProperty()

* ditto.

* Dealed with 1st Shade Color Step; 1st Shade Color Feather, 2nd Shade Color Step and 2nd Shade Color Feather.

* Applied GUI_RangeProperty() to _Tweak_ShadingGradeMapLevel, _StepOffset and _HighColor_Power.

* Replaced MaterialEditor.RangeProperty to GUI_RangeProperty for _tweak_LightDirection_MaskLevel, _Tweak_RimLightMaskLevel, _BlurLevelMatcap, _Tweak_MatCapUV and _RotateMatCapUV.

* Replaced MaterialEditor.RangeProperty to GUI_RangeProperty() for  _AR_OffsetU, _AR_OffsetV, _TessEdgeLength, _TessPhongStrength, _TessExtrusionAmount ,_RimLight_Power, _Ap_RimLight_Power and _GI_Intensity.

* Replaced MaterialEditor.RangeProperty to GUI_RangeProperty() for  _Tweak_MatcapMaskLevel, _Rotate_NormalMapForMatCapUV and RimLight_InsideMask.
* Repleaced MaterialEditor.FloatProperty to GUI_FloatProperty() for _Base_Speed.

* So did the same to _Outline_Width

* So did _Farthest_Distance and _Nearest_Distance.

* Same to _Rotate_EmissiveUV, _Offset_Z and _ColorShift_Speed.
* Started to implement GUI_ColorProperty()
Rpleaced MaterialEditor.ColorProperty() to above for _ViewShift.

* Rpleaced MaterialEditor.ColorProperty() to GUI_ColorProperty() for _Outline_Color, _RimLightColor, _Ap_RimLightColor and _ColorShift.
* Dealt with Rim Ligh mask thingies.

* Repleased almost "TBD" tips, except Rim Light Mask Level and GI Intensity.

* Added tips to "Render Queue"

* chores. such as spaces and periods in the tips.

* change `blend mode` to `blending mode`

* Renamed `Rim Light Power` to `Rim Light Level`.

* Renamed `MatCap Color map` to `MatCap map`

* Added tips to "Outline Mode"

* Chores. preriod.
Added tips to HDRP Tessellation Mode.
* Fixed: Rimlingt Mask was not working well. https://jira.unity3d.com/browse/GOKU-1245

* Updated tips for `Rim Light Mask` and `Rim Light Mask Level`
* fixed some spells in menu items and their tips.

* Applied feedback from Hiroki and nobuyuki.

* Applied feedback and added default value in GUI_RangeProperty()
* Fixed:  Error report from tessellation UI for URP. URP version doesn't support tessellation for now.

* Updated tips for Light Color effectiveness.

* Removed unnecessary parts from Scroll direction sentences. "The range is -1 to 1, defaulting to 0. "

* Fixed: Angel Ring Tips.
* Fixed tips in Shader settings.

* Fixed tips in Highlight settings.

* Did the same to rim light settings tab.

* Did the same to MatCap settings.

* So did the emission.

* Did the same to Angel Ring Projection.
* fixed-indent in UniversalToonBody.hlsl.

* replaced tabs to spaces.
* Legacy Tessellation shader is capable of 1 pass stereo rendering.

* updated CHANGELOG.md.
* Added LegacyStereoGraphicsTest-2019.4

* - Applied shader single instance stereo rendering bug fix in UTS2 to legacy shaders.
- Added Graphics Tests for legacy shader single instance stereo rendering.

* Added legacy pipeline single instance stereo rendering test for newer Unity than 2020.3

* edited .yamato/_editor.yml

* - Added UniverslGraphicsTest-2022.2 project
- Fixed URP shader compile erros on 2022.2 but not for alpha versions as `HADER_LIBRARY_VERSION_MAJOR`  is still `13` in Version.hlsl
- modefied legacy rp test files VM to RTX2080 to avoid test vm congestion.

* added win_dx11-urp-2022.yml and win_vukan_urp-2022.2.yml.

* fixed: UNITY_VERSION to be compared with to 202220 from 202200.
changed VM for win_vulkan_legacy and rths-dx11-legacy.

* ditto.

* disabled HDRP tests for 2022.2 for a while
changed dx12 hdrp project tests VM

* Disabled dx11 hdrp 2022.2 test.
* started to re-write documents [skip ci]

* Updated System requirements.

* updated TableOfContents.md, installation.md and README.md.

* Added some settings .md files and updated table of conents.

* Updated some .md files. [skip ci]

* fixed:wrong link for Highlight-Settings.md

* Fixed: Wrong link to Scene-Light.md. [skip ci]

* added images to describe mode deffernce.

* replaced some expression in Modes.md.

* Replaced `Modes` to `Mode` in documents.

* Updated ShpereStadard.pg and SphereWithAdvancd.png. [skip ci]

* updating shader-settings.md [skip ci]

* ditto.[skip ci]

* ditto. [skip ci]

* Replaced `Modes` to `Mode` in Parameter-settings.md

* Added description for Stencil and Stencil value to Shader-settings.md. [skip ci]

* FIxed link for `stencil-value` in a table.

* modified `stencil` description

* Added other items in Shader-settings.md. [skip ci]

* Re-added basic-settings.md [skip ci]

* Added components in shading-step-and-feather-settings.md [skip ci[

* Added compnents to Highlight-Settings.md. [skip ci]

* Added compnents into rim-light-settings.md

* Added components to MatCap-Settings.md.

* Added componets into Emissio-Setting.md and Rim-Light-Settings.md
Fixed tips for `Light Direction Rim light Level` in UTS3GUI.cs

* Added components to Metaverse-Settings.md, Outlin-Settings.md and Scene-Light.md. [skip ci]

* Added tessllation docs but the no contents in them. [skip ci]

* added contents in Angel-Ring-Settings.md, Tessallation-HDRP.md and Tessallation-Legacy.md. [skip ci]

* Rewrote overview. [skip ci]

* Fixed typo. from shure to sure. [skip ci]

* Added images to Basic-Settings.md [skip ci]

* Updated Basic-Setting.md [skip ci]

* merged development/v1

* Added Animation GIF to describe Apply to 1st/2nd shading map. [skip ci]

* Added 2nd shade texture maps to ducumentation~/images folder. [skip ci]

* Added images to describe NormalMap and its effectiveness.

* ditto [skip ci]

* Added Shading Position Map imeges to Basic-Settings.md. [skip ci]

* - Organized: Basic-Setting.md.
- Fixed: Tips for Basic-Settings in UTS3GUI.cs
- Fixed file-name typo for Parameter-Settings.md.

* Fixed: intendation and typo in Basic-Settings.md [skip ci]

* - Updating Shding-Step-and-Feather-Settings.md.
- Added BaseShadingFeather.gif and ColorStep.gif
[skip ci]

* - Updated the display size of gif in Shading-Step-and-Feather-Setting.md
- Added ShadingColorStep.gif
[skip ci]

* - re-saved Shading-Step-and-Feather-Settings.md [skip ci]

* - Added 1st2ndShadeFeather.gif [skip ci]

* - Added RecieveSystemShadow.gif. [skip ci]

* - Added SystemShadowLevel.gif. [skip ci]

* - Added PointLightStepOffset.gif [skip ci]

* - Added FilterHilightOnPointLight-2.gif [skip ci]

* updated Shading-Step-and-Feather-Settings.md. [skip ci]

* - Added PointLightStepOffset-Ball3.gif. [skip ci]

* Added FilterPointLightHighlihgt-Ball.gif [skip ci]

* - Started to edit Highliht-Settings.md
- Added Highlight.gif. [skip ci]

* - Added SpecularPower.gif. [skip ci]

* - Fixed: unnatural expression Multiply or Additive to Multiply or `Add`.
- Added HighlightBlendingLevel.gif, SpecularAdd.png, SpecularMultipy.png, SpecularSoft.png, SpecularHard.png.
- Updated Highlight-Settings.md. [skip ci]

* - Added description for `Highlight Mask`.
- Fixed: tips for Highlight Mask.

* - Updated Rim-Light-Settings.md
- Added RimLightColor.gif, RImLIghtOff.png and RimLightOn.png. [skip ci]

* - Updated Rim-Light-Settings.md
- Added AdjustRimLightArea.gif, RimLightFeatherOff.png, RimLightFeatherOn.png and RimLightLevel.gif. [skip ci]

* - Updated Rim-Light-Settings.md
- Adde RimLightDirectionOff.png and RimLightDirectionOn.png. [skip ci]

* Delete wrong name files. [skip ci]

* Re-Added the same files using right file-name. [skip ci]

* - Added /LightDirectionRimLightLevel.gif. [skip ci]

* - Added InversedLightDirectionRimLightOff.png and InversedLightDirectionRimLightOn.png. [skip ci]

* Fixed: Filename Typo `Rim-Light-Settingss.md`. [skip ci]

* - Added InversedRimLightColor.gif. [skip ci]

* Fixed: file name typo in `Parameter-Settings.md`. [skip ci]

* - Updated Rim-Light-Settings.md
- Added InversedRimLightLevel.gif, InversedRimLightFeathterOn.png and InversedRimLightFeathterOff.png.  [skip ci]

* Started to edit MatCap-Settings.md [skip ci]

* - Updated Rim-Light-Settings.md-
- Added RimLightMaskLevel.gif, RimLightMaskOff.png, RimLightMaskOn.png, UVCheckGrid.png. [skip ci]

* Added HIghtMaskLeve.gif HighLightMaskOff.png and HighLightMaskOn.png [skip ci]

* * Indentation of menu items in Updated Highlight-Settings.md [skip ci]

* Started to editEmission-Settings.md but find Unity logo was old.

* Updated Angel Ring Projection page. [skip ci]

* Added The color of the **Angel Ring** can be specified directly instead of using the additive method. [skip ci]

* - Added description for OffsetUV and AlphaChannel as Clipping Mask. [skip ci]

* Fixed: typo for default in Angel-Ring-Settings.md.

* Replaced Unity Log Texture to the new one. [skip ci]

* Replaced texture used in MatCap sample scenes. [skip ci]

* Added action.yml to check markdown file dead links. [skip ci]

* tentatively deleted Mac test because of the UTR issue.

* Editing Emission-Settings.md [skip ci]

* Added EmissionMapViewCoordinateScroll.gif. [skip ci]

* Added RotttateAroundUVCenter2.gif.  [skip ci]

* Added EmissionMapSample.png and RoateAroundUVCenter3.gif. [skip ci]

* Added ColorShiftingWithTime.gif. [skip ci]

* Added ColorShiftingWithView.gif.

* Added a script, CameraController2.cs [skip ci]

* Updated the script to evluate curve. [skip ci]

* - Added some MatCap images in the image folder. [skip ci]

* Added Some .gifs in Documation~/images.

* Added some imaged to describe matcap features. [skip ci]

* ditto.

* Disabled showing Unitychan Toon Shader 2 converter window on start up.

* Updated intendentation in .md files.

* Added image OutlineOff.png and OutlineOn.png.

* Added some images to describe outline.
* - Renamed what's new-0.x.0.md to what's new-0.x.x.md.
- Added Whats-new-0.7x.md and Whats-new-0.6.x.md.

* Renamed some `*-Settings.md` files not make help URL work.

* Fixed typo for Rimlight.md.
* Updating some settings .md files [skip ci]

* Fixed typo in Shader.md.

* - Disabled converter window on starting up.

* Fixed: wrong url reference for github docs.

* - Added LightLimitIntensityOn/Off.png
- Updated SceneLight.md.
-  Added Tips to GI Intensity in UTS3GUI.cs [skip ci]

* - Updated SceneLight.md
- Added SceneLightFffectiveness0.png and 1.png
- Added SceneLightEffectivenessOff.png and SceneLightEffectivenessOn.png.

* - Removed markdown link check action as it doesn't check link in the same file.
* - Fixed: HDRP-compilation errors on 2022.2. [skip ci]

* Added HDRP graphics tests for 2022.2.x
* - Added a project, UniversalStereoGraphicsTest-2019.4.
- Added win_dx11-urp-stereo-2019.4.yml

* - removed other versions from UniversalStereoGraphicsTest-2019.4. only 2019.4 is left in the test yml file. [skip ci]

* Added Unversal Stereo graphics test project for later than 2020.3.
* - rewrote whats-new-0.7.x.md [skip ci]
- rewrote whats-new-0.6.x.md

* Updated feature model adding 3.2. [skip ci]

* Added descripton for instanced stereo rendering to FeatureModel.md. [skip ci]

* ditto [skip ci]
* - edited metaverse settings. [skip ci]

* - Updated Parameter-Settings.md [skip ci]
* - Started to Add `Create A Pre-Release` job in upm-ci-uts2.yml [skip ci]

* - modefined VM in upm-ci-uts2.yml
- added package-path for publish_dry_run. [skip ci]

* * Renamed `GI Intesity` to `Light Probe Intensity`
- Added sample images to describe LIght Probe Intsnsity.
- Updated SceneLight.md.

* - Added BlendBaseColorToOutlineOff and On to describe  `Blend Base Color to Outline`. [skip ci]
* - Started to Add `Create A Pre-Release` job in upm-ci-uts2.yml [skip ci]

* - modefined VM in upm-ci-uts2.yml
- added package-path for publish_dry_run. [skip ci]

* removed instruction.md. [skip ci]
- updated `System-Requirements.md`.
- changed maxversion  from 2022.1 to 2022.2. [skip ci[
sindharta and others added 28 commits March 19, 2025 09:45
* refactor metal CI 
* delete other metal CI files
* refer to metal_platform variable
* use the correct Unity version
* remove dependencies (not required)
…rward+ settings (#404)

* upgrade assets
* upgrade materials
* upgrade settings
* delete boot.config
* upgrade packages
* update asset
* update forward+
* update asset
* set graphics test timeout to 1 hour
* refactor DX11 CI
* remove dependencies
* refactor DX12 CI
* refactor Vulkan CI
* specify unity version
* delete most Win CI jobs
* refer to metafile
* use choco-install
* chore: add .buginfo
* exclude .buginfo from being included in the package via npmignore
* rename file
* rename the variable for OSX test projects
* rename the variable for Win test projects
* remove windows.yml
…es in test projects (#408)

* add script
* fix script
… Window Settings (#409)

* add newlines
* Highlight page
* Rimlight page
* Emission page
* Matcap page
* Outline page
* trigger
* turn tests trigger into a virtual job
* upgrade to 2022
* add settings
* rename project
* update Yamato
#414)

* calling InitializeBacedGIData() is necessary  for  newer than 6000.0.0.

* The version split InputData init was from 6000.0.12, not 6000.0.0.

---------

Co-authored-by: H3idi-X <>
#411)

* Remove 2021 projects
* update Yamato job file
* remove unnecessary packages
* remove the use of RaytracedHardShadow packages
* update settings
* update meta
* embed config
…#420)

* HDRP
* legacy
* URP
* remove the use of com.unity.ai.navigation and RTHS packages
* remove other unnecessary packages
* upgrade IDE packages
…est (#423)

* delete UnityChan assets in the test project
* use symlink
For preparation to share the same Monobehaviour in all test projects.
The change to use the same script will be done in a separate PR.
…cts (#425)

With two exceptions due to errors at the moment:
* HdrpGraphicsTest-2022.3
* HdrpGraphicsTest-6000.0
* add com.unity.toon-graphics-test internal package as the placeholder for test scripts
* use the new internal package inside manifests
* move UTSGraphicsTestSetup.cs and UTS_GraphicsTestSettings.cs
* use symbolic links
* update the assemblies in the project to refer to the new internal package
* rename LegacyUTS_GraphicsTestSettings to UTS_GraphicsTestSettings
* rename HDRPUTS_GraphicsTestSettings to UTS_GraphicsTestSettings
* rename UniversalUTS_GraphicsTestSettings to UTS_GraphicsTestSettings
* add metaverse materials in the sample folder
* add prefabs that uses the metaverse materials
* add the same materials and prefabs in the 2022.3 test project
* add the same materials and prefabs in the 6000 test project
* update scene to use metaverse prefab
* disable components in the Unity-Chan prefab in test projects
…t-2022.3 and HdrpGraphicsTest-6000.0 (#429)

* remove UnityChan assets in the test projects
* use symlink
@unity-cla-assistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 5 committers have signed the CLA.

✅ sindharta
✅ sindharta-tanuwijaya
❌ H3idi-X
❌ markg-unity
❌ sebastienduverne
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants